Bug #1092

Log causes stack trace when logging faulty unicode conversion attempts

Added by Joel Palmius about 2 years ago. Updated almost 2 years ago.

Status:RejectedStart date:01/09/2017
Priority:NormalDue date:
Assignee:Joel Palmius% Done:

0%

Category:Code correctness
Target version:MakeHuman 1.1.2

Description

(from #1029)

In getpath, stringToUnicode, there is a last fallback where a destructive conversion to utf8 is made. After that, there is a try/except where strings are concatenated in order to print the faulty string.

Unfortunately, the string concatenation will fail and cause a exception in python's log module, not in getpath, when a normal string and a faulty string is concatenated. For some reason this exception is not caught (maybe the actual python logging is asynchronous and takes place in another thread?).

The only problem this causes is that a spurious stack trace ends up in the log in rare cases. Won't fix this for 1.1.1.

History

#1 Updated by Joel Palmius almost 2 years ago

  • Status changed from New to Rejected

Won't fix this for 1.1.1.

Actually, I did fix this for 1.1.1.

(it now logs a hex dump of the string instead)

Also available in: Atom